Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added api-version parameter in agreements APIs #12565

Merged
merged 4 commits into from
Jan 29, 2021
Merged

added api-version parameter in agreements APIs #12565

merged 4 commits into from
Jan 29, 2021

Conversation

alluri02
Copy link
Contributor

@alluri02 alluri02 commented Jan 22, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @alluri02 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 22, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1010 - AddingRequiredParameter The required parameter 'api-version' was added in the new version.
    New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L46:9
    ❌ 1010 - AddingRequiredParameter The required parameter 'api-version' was added in the new version.
    New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L91:9
    ❌ 1010 - AddingRequiredParameter The required parameter 'api-version' was added in the new version.
    New: Microsoft.Confluent/stable/2020-03-01/confluent.json#L46:9
    ❌ 1010 - AddingRequiredParameter The required parameter 'api-version' was added in the new version.
    New: Microsoft.Confluent/stable/2020-03-01/confluent.json#L91:9
    ❌ 1042 - ChangedParameterOrder The order of parameter 'body' was changed.
    New: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L91:9
    Old: Microsoft.Confluent/preview/2020-03-01-preview/confluent.json#L88:9
    ❌ 1042 - ChangedParameterOrder The order of parameter 'body' was changed.
    New: Microsoft.Confluent/stable/2020-03-01/confluent.json#L91:9
    Old: Microsoft.Confluent/stable/2020-03-01/confluent.json#L88:9
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 22, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c35467e. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/confluent/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OrganizationResourceProperties-offerDetail' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OrganizationResourceProperties-userDetail' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OrganizationResource-properties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OrganizationResourceProperties-offerDetail' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OrganizationResourceProperties-userDetail' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OrganizationResource-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'organization_resource_properties' -> 'organization_resource_propertiesAutoGenerated'
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /MarketplaceAgreements/get/MarketplaceAgreements_List
cmderr	[Autorest]     - name: /Organization/put/Organization_Create
cmderr	[Autorest]     - name: /Organization/get/Organization_Get
cmderr	[Autorest]     - name: /Organization/get/Organization_ListByResourceGroup
cmderr	[Autorest]     - name: /Organization/get/Organization_ListBySubscription
cmderr	[Autorest]     - name: /Organization/patch/Confluent_Update
cmderr	[Autorest]     - name: /Organization/delete/Confluent_Delete
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
    • ️✔️confluent [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c35467e. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️confluent/mgmt/2020-03-01/confluent [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/confluent/mgmt/2020-03-01-preview/confluent [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Properties` of struct `AgreementResource` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `*AgreementResource.UnmarshalJSON([]byte) error`
info	[Changelog] - New anonymous field `*AgreementProperties` in struct `AgreementResource`
info	[Changelog] - New field `IsDataAction` in struct `OperationResult`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 3 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-python-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c35467e. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=3.0.6272 --use=@autorest/[email protected] --python --python-mode=update --multiapi --track2 --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/confluent/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OrganizationResourceProperties-offerDetail' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OrganizationResourceProperties-userDetail' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OrganizationResource-properties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OrganizationResourceProperties-offerDetail' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OrganizationResourceProperties-userDetail' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OrganizationResource-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'OrganizationResourceProperties' -> 'OrganizationResourcePropertiesAutoGenerated'
    • ️✔️track2_azure-mgmt-confluent [View full logs]  [Release SDK Changes] 
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-confluent
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-confluent
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Building code report of azure-mgmt-confluent for version None in default folder (False/False/False)
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.confluent
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.confluent
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.confluent
cmderr	[changelogReport] INFO:__main__:Report written to sdk/confluent/azure-mgmt-confluent/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-confluent for version None in default folder (False/False/True)
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-confluent on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['1.0.0b1', '1.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0 of azure-mgmt-confluent in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-confluent for version 1.0.0 in default folder (True/False/False)
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.confluent
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.confluent
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.confluent
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/confluent/azure-mgmt-confluent/code_reports/1.0.0/report.json
cmderr	[changelogReportLatest] INFO:__main__:Writing metadata: {'reports': ['sdk/confluent/azure-mgmt-confluent/code_reports/1.0.0/report.json']}
cmdout	[Changelog] Size of delta 3.206% size of original (original: 11165 chars, delta: 358 chars)
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c35467e. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/confluent/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Confluent [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c35467e. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/confluent/resource-manager/readme.md
    • ️✔️@azure/arm-confluent [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/confluentManagementClient.js → ./dist/arm-confluent.js...
cmderr	[npmPack] created ./dist/arm-confluent.js in 239ms
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c35467e. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-29 02:26:36 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-confluent;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-01-29 02:26:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-01-29 02:26:36 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/confluent/azure-resourcemanager-confluent --java.namespace=com.azure.resourcemanager.confluent   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/confluent/resource-manager/readme.md
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-confluent
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [POM][Skip] pom already has module azure-resourcemanager-confluent
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [POM][Skip] pom already has module sdk/confluent
cmderr	[generate.py] 2021-01-29 02:27:16 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-confluent [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-29 02:29:55 DEBUG Got artifact_id: azure-resourcemanager-confluent
cmderr	[Inst] 2021-01-29 02:29:55 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-29 02:29:55 DEBUG Got artifact: azure-resourcemanager-confluent-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-01-29 02:29:55 DEBUG Got artifact: azure-resourcemanager-confluent-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-01-29 02:29:55 DEBUG Got artifact: azure-resourcemanager-confluent-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-29 02:29:55 DEBUG Match jar package: azure-resourcemanager-confluent-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-29 02:29:55 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12565/azure-sdk-for-java/azure-resourcemanager-confluent/azure-resourcemanager-confluent-1.0.0-beta.2.jar\" -o azure-resourcemanager-confluent-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-confluent -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-confluent-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c35467e. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/confluent/resource-manager/readme.md
    • ️✔️confluent [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN [email protected] No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @alluri02, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Jan 22, 2021
    Closed
    Closed
    This was referenced Jan 22, 2021
    Closed
    Closed
    Closed
    Closed
    @alluri02 alluri02 marked this pull request as ready for review January 27, 2021 16:46
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 27, 2021
    @alluri02
    Copy link
    Contributor Author

    hi @ruowan, can you please approve this PR?

    @ruowan ruowan merged commit c35467e into master Jan 29, 2021
    This was referenced Jan 29, 2021
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    This was referenced Jan 29, 2021
    Closed
    Closed
    @mikhailshilkov mikhailshilkov mentioned this pull request Jan 30, 2021
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @alluri02 @mkarmark
    added api-version parameter in agreements APIs (Azure#12565)
    5759d11 
    * added api-version parameter in agreements apis

* updated api-version parameter

* updated confluent.json

* updated confluent.json
    @JackTn JackTn deleted the confluent-patch2201 branch August 9, 2021 10:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ruowan ruowan ruowan approved these changes

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    Assignees

    @ruowan ruowan

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @alluri02 @JeffreyRichter @ruowan